max/embassy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
James Munns 2023-03-27 18:21:11 +02:00
parent a77fdefd7c
commit 20aa86d63e
2 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
embassy-usb/src/builder.rs
View File

@ -207,15 +207,7 @@ impl<'d, D: Driver<'d>> Builder<'d, D> {
info!("USB: bos_descriptor used: {}", self.bos_descriptor.writer.position()); info!("USB: bos_descriptor used: {}", self.bos_descriptor.writer.position());
#[cfg(feature = "msos-descriptor")] #[cfg(feature = "msos-descriptor")]
info!("USB: msos_descriptor used: {}", msos_descriptor.len()); info!("USB: msos_descriptor used: {}", msos_descriptor.len());
if self.control_buf.len() != self.config.max_packet_size_0.into() {
warn!(
"USB: Mismatch in control buf and max packet size! buf len: {}, max ep0 size: {}",
self.control_buf.len(),
self.config.max_packet_size_0,
);
} else {
info!("USB: control_buf size: {}", self.control_buf.len()); info!("USB: control_buf size: {}", self.control_buf.len());
}
UsbDevice::build( UsbDevice::build(
self.driver, self.driver,

4
embassy-usb/src/class/hid.rs
View File

@ -458,8 +458,8 @@ impl<'d> Handler for Control<'d> {
return None; return None;
} }
// TODO(AJM): This uses a defmt-specific formatter that causes use of the `log` // This uses a defmt-specific formatter that causes use of the `log`
// feature to fail to build // feature to fail to build, so leave it defmt-specific for now.
#[cfg(feature = "defmt")] #[cfg(feature = "defmt")]
trace!("HID control_out {:?} {=[u8]:x}", req, data); trace!("HID control_out {:?} {=[u8]:x}", req, data);
match req.request { match req.request {