max/embassy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix stm32 warnings

Browse Source
This commit is contained in:
Rukai
2021-07-03 22:05:12 +10:00
committed by Dario Nieuwenhuis
parent 8615ffb523
commit 25d4b2ea26
8 changed files with 24 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
embassy-stm32/src/adc/mod.rs
View File

@ -6,12 +6,9 @@ mod _version;
#[allow(unused)]
pub use _version::*;
use crate::gpio::NoPin;
use crate::peripherals;
pub(crate) mod sealed {
use crate::gpio::Pin;
pub trait Instance {
fn regs() -> &'static crate::pac::adc::Adc;
fn common_regs() -> &'static crate::pac::adccommon::AdcCommon;

8
embassy-stm32/src/adc/v3.rs
View File

@ -1,10 +1,9 @@
use crate::adc::{AdcPin, Instance};
use core::convert::Infallible;
use core::marker::PhantomData;
use cortex_m::delay::Delay;
use embassy::util::Unborrow;
use embassy_extras::unborrow;
use embedded_hal::blocking::delay::{DelayMs, DelayUs};
use embedded_hal::blocking::delay::DelayUs;
pub const VDDA_CALIB_MV: u32 = 3000;
@ -193,6 +192,7 @@ impl<'d, T: Instance> Adc<'d, T> {
/// Calculates the system VDDA by sampling the internal VREF channel and comparing
/// the result with the value stored at the factory. If the chip's VDDA is not stable, run
/// this before each ADC conversion.
#[allow(unused)] // TODO is this supposed to be public?
fn calibrate(&mut self, vref: &mut Vref) {
let vref_cal = unsafe { crate::pac::VREFINTCAL.data().read().value() };
let old_sample_time = self.sample_time;
@ -233,8 +233,6 @@ impl<'d, T: Instance> Adc<'d, T> {
*/
pub fn read(&mut self, pin: &mut impl AdcPin<T>) -> u16 {
let v = pin.channel();
unsafe {
// Make sure bits are off
while T::regs().cr().read().addis() {
@ -304,7 +302,7 @@ impl<'d, T: Instance> Adc<'d, T> {
}
unsafe fn set_channel_sample_time(ch: u8, sample_time: SampleTime) {
if ch >= 0 && ch <= 9 {
if ch <= 9 {
T::regs()
.smpr1()
.modify(|reg| reg.set_smp(ch as _, sample_time.sample_time()));