max/embassy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

write to TaskStorage::future via inline(never) fn to encourage RVO

Browse Source
This commit is contained in:
Hailey Somerville 2023-09-14 13:03:38 +10:00
parent 5e381d49da
commit 3a1ed823f8
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
embassy-executor/src/raw/mod.rs
View File

@ -203,7 +203,7 @@ impl<F: Future + 'static> AvailableTask<F> {
fn initialize_impl<S>(self, future: impl FnOnce() -> F) -> SpawnToken<S> { fn initialize_impl<S>(self, future: impl FnOnce() -> F) -> SpawnToken<S> {
unsafe { unsafe {
self.task.raw.poll_fn.set(Some(TaskStorage::<F>::poll)); self.task.raw.poll_fn.set(Some(TaskStorage::<F>::poll));
self.task.future.write(future()); self.task.future.write_in_place(future);
let task = TaskRef::new(self.task); let task = TaskRef::new(self.task);

5
embassy-executor/src/raw/util.rs
View File

@ -17,8 +17,9 @@ impl<T> UninitCell<T> {
&mut *self.as_mut_ptr() &mut *self.as_mut_ptr()
} }
pub unsafe fn write(&self, val: T) { #[inline(never)]
ptr::write(self.as_mut_ptr(), val) pub unsafe fn write_in_place(&self, func: impl FnOnce() -> T) {
ptr::write(self.as_mut_ptr(), func())
} }
pub unsafe fn drop_in_place(&self) { pub unsafe fn drop_in_place(&self) {