max/embassy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clean up some todo comments around infinite play

Browse Source
This commit is contained in:
Jacob Rosenthal 2021-11-03 18:46:42 -07:00
parent b726ef1886
commit 64e1426b54
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
embassy-nrf/src/pwm.rs
View File

@ -146,7 +146,6 @@ impl<'d, T: Instance> SequencePwm<'d, T> {
r.enable.write(|w| w.enable().enabled()); r.enable.write(|w| w.enable().enabled());
match times { match times {
// todo why doesn't this play forever? set_duty does...
// just the one time, no loop count // just the one time, no loop count
SequenceMode::Times(1) => { SequenceMode::Times(1) => {
r.loop_.write(|w| w.cnt().disabled()); r.loop_.write(|w| w.cnt().disabled());
@ -400,7 +399,6 @@ impl<'d, T: Instance> SimplePwm<'d, T> {
// todo justify? should i fence elsehwere we task start? or // todo justify? should i fence elsehwere we task start? or
compiler_fence(Ordering::SeqCst); compiler_fence(Ordering::SeqCst);
// todo why does this play forever when times(1) doesn't?
// tasks_seqstart() doesn't exist in all svds so write its bit instead // tasks_seqstart() doesn't exist in all svds so write its bit instead
r.tasks_seqstart[0].write(|w| unsafe { w.bits(1) }); r.tasks_seqstart[0].write(|w| unsafe { w.bits(1) });
} }