diff --git a/embassy-stm32/src/usart/mod.rs b/embassy-stm32/src/usart/mod.rs index 07406121..3f5b9952 100644 --- a/embassy-stm32/src/usart/mod.rs +++ b/embassy-stm32/src/usart/mod.rs @@ -222,10 +222,48 @@ impl<'d, T: BasicInstance, TxDma, RxDma> Uart<'d, T, TxDma, RxDma> { rx_dma: impl Peripheral
+ 'd, config: Config, ) -> Self { - into_ref!(_inner, rx, tx, tx_dma, rx_dma); + T::enable(); + T::reset(); + + Self::new_inner(_inner, rx, tx, tx_dma, rx_dma, config) + } + + pub fn new_with_rtscts( + _inner: impl Peripheral
+ 'd, + rx: impl Peripheral
> + 'd, + tx: impl Peripheral
> + 'd, + rts: impl Peripheral
> + 'd, + cts: impl Peripheral
> + 'd, + tx_dma: impl Peripheral
+ 'd, + rx_dma: impl Peripheral
+ 'd, + config: Config, + ) -> Self { + into_ref!(cts, rts); T::enable(); T::reset(); + + unsafe { + rts.set_as_af(rts.af_num(), AFType::OutputPushPull); + cts.set_as_af(cts.af_num(), AFType::Input); + T::regs().cr3().write(|w| { + w.set_rtse(true); + w.set_ctse(true); + }); + } + Self::new_inner(_inner, rx, tx, tx_dma, rx_dma, config) + } + + fn new_inner( + _inner: impl Peripheral
+ 'd, + rx: impl Peripheral
> + 'd, + tx: impl Peripheral
> + 'd, + tx_dma: impl Peripheral
+ 'd, + rx_dma: impl Peripheral
+ 'd, + config: Config, + ) -> Self { + into_ref!(_inner, rx, tx, tx_dma, rx_dma); + let pclk_freq = T::frequency(); // TODO: better calculation, including error checking and OVER8 if possible. @@ -264,29 +302,6 @@ impl<'d, T: BasicInstance, TxDma, RxDma> Uart<'d, T, TxDma, RxDma> { } } - pub fn new_with_rtscts( - _inner: impl Peripheral
+ 'd, - rx: impl Peripheral
> + 'd, - tx: impl Peripheral
> + 'd, - rts: impl Peripheral
> + 'd, - cts: impl Peripheral
> + 'd, - tx_dma: impl Peripheral
+ 'd, - rx_dma: impl Peripheral
+ 'd,
- config: Config,
- ) -> Self {
- into_ref!(cts, rts);
-
- unsafe {
- rts.set_as_af(rts.af_num(), AFType::OutputPushPull);
- cts.set_as_af(cts.af_num(), AFType::Input);
- T::regs().cr3().write(|w| {
- w.set_rtse(true);
- w.set_ctse(true);
- });
- }
- Self::new(_inner, rx, tx, tx_dma, rx_dma, config)
- }
-
pub async fn write(&mut self, buffer: &[u8]) -> Result<(), Error>
where
TxDma: crate::usart::TxDma