max/embassy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

stm32: fix set_config for buffered uart

Browse Source 
In reconfigure() cr1 register is initialised with write (not modify) which means rxneie and idleneie are disabled after reconfiguration.
This commit is contained in:
Andres Vahter 2023-10-23 22:43:15 +03:00
parent 188ee59ba6
commit 7f72dbdaf2
1 changed files with 34 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
embassy-stm32/src/usart/buffered.rs
View File

@ -233,7 +233,7 @@ impl<'d, T: BasicInstance> BufferedUart<'d, T> {
configure(r, &config, T::frequency(), T::KIND, true, true)?; configure(r, &config, T::frequency(), T::KIND, true, true)?;
r.cr1().modify(|w| { r.cr1().modify(|w| {
#[cfg(lpuart_v2)] #[cfg(usart_v4)]
w.set_fifoen(true); w.set_fifoen(true);
w.set_rxneie(true); w.set_rxneie(true);
@ -254,7 +254,17 @@ impl<'d, T: BasicInstance> BufferedUart<'d, T> {
} }
pub fn set_config(&mut self, config: &Config) -> Result<(), ConfigError> { pub fn set_config(&mut self, config: &Config) -> Result<(), ConfigError> {
reconfigure::<T>(config) reconfigure::<T>(config)?;
T::regs().cr1().modify(|w| {
#[cfg(usart_v4)]
w.set_fifoen(true);
w.set_rxneie(true);
w.set_idleie(true);
});
Ok(())
} }
} }
@ -334,7 +344,17 @@ impl<'d, T: BasicInstance> BufferedUartRx<'d, T> {
} }
pub fn set_config(&mut self, config: &Config) -> Result<(), ConfigError> { pub fn set_config(&mut self, config: &Config) -> Result<(), ConfigError> {
reconfigure::<T>(config) reconfigure::<T>(config)?;
T::regs().cr1().modify(|w| {
#[cfg(usart_v4)]
w.set_fifoen(true);
w.set_rxneie(true);
w.set_idleie(true);
});
Ok(())
} }
} }
@ -408,7 +428,17 @@ impl<'d, T: BasicInstance> BufferedUartTx<'d, T> {
} }
pub fn set_config(&mut self, config: &Config) -> Result<(), ConfigError> { pub fn set_config(&mut self, config: &Config) -> Result<(), ConfigError> {
reconfigure::<T>(config) reconfigure::<T>(config)?;
T::regs().cr1().modify(|w| {
#[cfg(usart_v4)]
w.set_fifoen(true);
w.set_rxneie(true);
w.set_idleie(true);
});
Ok(())
} }
} }