max/embassy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

STM32: Don't enable opamps in new(), wait until configured.

Browse Source
This commit is contained in:
Adam Greig 2023-11-18 19:37:56 +00:00
parent 5bc7557826
commit 814e096d22
No known key found for this signature in database
GPG Key ID: 8B3FE5477B1DD9A0
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
embassy-stm32/src/opamp.rs
View File

@ -54,19 +54,12 @@ pub struct OpAmp<'d, T: Instance> {
impl<'d, T: Instance> OpAmp<'d, T> { impl<'d, T: Instance> OpAmp<'d, T> {
/// Create a new driver instance. /// Create a new driver instance.
/// ///
/// Enables the OpAmp and configures the speed, but /// Does not enable the opamp, but does set the speed mode on some families.
/// does not set any other configuration.
pub fn new(opamp: impl Peripheral<P = T> + 'd, #[cfg(opamp_g4)] speed: OpAmpSpeed) -> Self { pub fn new(opamp: impl Peripheral<P = T> + 'd, #[cfg(opamp_g4)] speed: OpAmpSpeed) -> Self {
into_ref!(opamp); into_ref!(opamp);
#[cfg(opamp_f3)]
T::regs().opampcsr().modify(|w| {
w.set_opampen(true);
});
#[cfg(opamp_g4)] #[cfg(opamp_g4)]
T::regs().opamp_csr().modify(|w| { T::regs().opamp_csr().modify(|w| {
w.set_opaen(true);
w.set_opahsm(speed.into()); w.set_opahsm(speed.into());
}); });
@ -74,7 +67,7 @@ impl<'d, T: Instance> OpAmp<'d, T> {
} }
/// Configure the OpAmp as a buffer for the provided input pin, /// Configure the OpAmp as a buffer for the provided input pin,
/// outputting to the provided output pin. /// outputting to the provided output pin, and enable the opamp.
/// ///
/// The input pin is configured for analogue mode but not consumed, /// The input pin is configured for analogue mode but not consumed,
/// so it may subsequently be used for ADC or comparator inputs. /// so it may subsequently be used for ADC or comparator inputs.
@ -129,7 +122,7 @@ impl<'d, T: Instance> OpAmp<'d, T> {
} }
/// Configure the OpAmp as a buffer for the provided input pin, /// Configure the OpAmp as a buffer for the provided input pin,
/// with the output only used internally. /// with the output only used internally, and enable the opamp.
/// ///
/// The input pin is configured for analogue mode but not consumed, /// The input pin is configured for analogue mode but not consumed,
/// so it may be subsequently used for ADC or comparator inputs. /// so it may be subsequently used for ADC or comparator inputs.