689: Avoid writing bootloader flash if not needed r=lulf a=lulf

bors r+

Co-authored-by: Ulf Lilleengen <lulf@redhat.com>
This commit is contained in:
bors[bot] 2022-03-31 13:24:25 +00:00 committed by GitHub
commit a9e63167e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -318,6 +318,11 @@ impl FirmwareUpdater {
#[repr(align(4))] #[repr(align(4))]
struct Aligned([u8; 4]); struct Aligned([u8; 4]);
let mut magic = Aligned([0; 4]);
flash.read(self.state.from as u32, &mut magic.0).await?;
let magic = u32::from_le_bytes(magic.0);
if magic != SWAP_MAGIC {
flash flash
.write(self.state.from as u32, &Aligned([0; 4]).0) .write(self.state.from as u32, &Aligned([0; 4]).0)
.await?; .await?;
@ -333,6 +338,7 @@ impl FirmwareUpdater {
flash flash
.write(self.state.from as u32, &SWAP_MAGIC.to_le_bytes()) .write(self.state.from as u32, &SWAP_MAGIC.to_le_bytes())
.await?; .await?;
}
Ok(()) Ok(())
} }
@ -341,6 +347,11 @@ impl FirmwareUpdater {
#[repr(align(4))] #[repr(align(4))]
struct Aligned([u8; 4]); struct Aligned([u8; 4]);
let mut magic = Aligned([0; 4]);
flash.read(self.state.from as u32, &mut magic.0).await?;
let magic = u32::from_le_bytes(magic.0);
if magic != BOOT_MAGIC {
flash flash
.write(self.state.from as u32, &Aligned([0; 4]).0) .write(self.state.from as u32, &Aligned([0; 4]).0)
.await?; .await?;
@ -350,6 +361,7 @@ impl FirmwareUpdater {
flash flash
.write(self.state.from as u32, &BOOT_MAGIC.to_le_bytes()) .write(self.state.from as u32, &BOOT_MAGIC.to_le_bytes())
.await?; .await?;
}
Ok(()) Ok(())
} }