max/embassy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hal-common: require DerefMut for peripherals, not just Deref.

Browse Source 
Otherwise you can create multiple drivers on the same singleton like this:

```rust
let mut input = Input::new(&pin, Pull::None);
let mut output = Output::new(&pin, Level::Low, Speed::Low);
input.is_high();
output.set_high();
input.is_high();
output.set_high();
```

Thanks @pennae for reporting.
This commit is contained in:
Dario Nieuwenhuis 2023-07-02 22:07:20 +02:00
parent ba43444292
commit c9b9be5b81
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
embassy-hal-common/src/peripheral.rs
View File

@ -161,7 +161,7 @@ pub trait Peripheral: Sized {
} }
} }
impl<'b, T: Deref> Peripheral for T impl<'b, T: DerefMut> Peripheral for T
where where
T::Target: Peripheral, T::Target: Peripheral,
{ {

4
embassy-stm32/src/dac/mod.rs
View File

@ -264,7 +264,7 @@ impl<'d, T: Instance, Tx> DacCh1<'d, T, Tx> {
}); });
let tx_request = self.dma.request(); let tx_request = self.dma.request();
let dma_channel = &self.dma; let dma_channel = &mut self.dma;
let tx_options = crate::dma::TransferOptions { let tx_options = crate::dma::TransferOptions {
circular, circular,
@ -376,7 +376,7 @@ impl<'d, T: Instance, Tx> DacCh2<'d, T, Tx> {
}); });
let tx_request = self.dma.request(); let tx_request = self.dma.request();
let dma_channel = &self.dma; let dma_channel = &mut self.dma;
let tx_options = crate::dma::TransferOptions { let tx_options = crate::dma::TransferOptions {
circular, circular,