max/embassy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unsafe from new on RND

Browse Source 
Unsafe is not required here given that all futures are required to live longer than their global peripheral instances. There are other occurrences of unsafe being used on new that should be removed. I started to do that but then went down a bit of a rabbit hole.
This commit is contained in:
huntc 2022-01-06 09:59:28 +11:00
parent da0c25227f
commit d5d8897c84
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
embassy-nrf/src/rng.rs
View File

@ -52,7 +52,7 @@ impl<'d> Rng<'d> {
/// e.g. using `mem::forget`. /// e.g. using `mem::forget`.
/// ///
/// The synchronous API is safe. /// The synchronous API is safe.
pub unsafe fn new( pub fn new(
_rng: impl Unborrow<Target = RNG> + 'd, _rng: impl Unborrow<Target = RNG> + 'd,
irq: impl Unborrow<Target = interrupt::RNG> + 'd, irq: impl Unborrow<Target = interrupt::RNG> + 'd,
) -> Self { ) -> Self {

2
examples/nrf/src/bin/rng.rs
View File

@ -15,7 +15,7 @@ use rand::Rng as _;
#[embassy::main] #[embassy::main]
async fn main(_spawner: Spawner, p: Peripherals) { async fn main(_spawner: Spawner, p: Peripherals) {
let mut rng = unsafe { Rng::new(p.RNG, interrupt::take!(RNG)) }; let mut rng = Rng::new(p.RNG, interrupt::take!(RNG));
// Async API // Async API
let mut bytes = [0; 4]; let mut bytes = [0; 4];