From e0183f4495d937e1b11bd2ecb2871f42aac86c3e Mon Sep 17 00:00:00 2001
From: xoviat <xoviat@gmail.com>
Date: Thu, 21 Jan 2021 10:59:14 -0600
Subject: [PATCH] optimize interruptfuture

remove critical secitons, impl. Unpin
---
 embassy/src/util/signal.rs | 40 +++++++++++++++++---------------------
 1 file changed, 18 insertions(+), 22 deletions(-)

diff --git a/embassy/src/util/signal.rs b/embassy/src/util/signal.rs
index 28f86505..2c9c52f1 100644
--- a/embassy/src/util/signal.rs
+++ b/embassy/src/util/signal.rs
@@ -86,20 +86,17 @@ pub struct InterruptFuture<'a, I: OwnedInterrupt> {
 
 impl<'a, I: OwnedInterrupt> Drop for InterruptFuture<'a, I> {
     fn drop(&mut self) {
-        cortex_m::interrupt::free(|_| {
-            self.interrupt.remove_handler();
-            self.interrupt.disable();
-        });
+        self.interrupt.disable();
+        self.interrupt.remove_handler();
     }
 }
 
 impl<'a, I: OwnedInterrupt> InterruptFuture<'a, I> {
     pub fn new(interrupt: &'a mut I) -> Self {
-        cortex_m::interrupt::free(|_| {
-            interrupt.set_handler(Self::interrupt_handler, ptr::null_mut());
-            interrupt.unpend();
-            interrupt.enable();
-        });
+        interrupt.disable();
+        interrupt.set_handler(Self::interrupt_handler, ptr::null_mut());
+        interrupt.unpend();
+        interrupt.enable();
 
         Self {
             interrupt: interrupt,
@@ -120,22 +117,21 @@ impl<'a, I: OwnedInterrupt> InterruptFuture<'a, I> {
     }
 }
 
+impl<'a, I: OwnedInterrupt> Unpin for InterruptFuture<'a, I> {}
+
 impl<'a, I: OwnedInterrupt> Future for InterruptFuture<'a, I> {
     type Output = ();
 
     fn poll(self: core::pin::Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<()> {
-        cortex_m::interrupt::free(|_| unsafe {
-            let s = self.get_unchecked_mut();
-            if s.interrupt.is_enabled() {
-                s.interrupt.set_handler(
-                    Self::interrupt_handler,
-                    executor::raw::task_from_waker(&cx.waker()).cast().as_ptr(),
-                );
-
-                Poll::Pending
-            } else {
-                Poll::Ready(())
-            }
-        })
+        let s = unsafe { self.get_unchecked_mut() };
+        s.interrupt.set_handler(
+            Self::interrupt_handler,
+            executor::raw::task_from_waker(&cx.waker()).cast().as_ptr(),
+        );
+        if s.interrupt.is_enabled() {
+            Poll::Pending
+        } else {
+            Poll::Ready(())
+        }
     }
 }