Address review comments

2022-02-09 12:46:46 +01:00
parent ed2a87a262
commit e990021b9a
2 changed files with 11 additions and 1 deletions
--- a/embassy-boot/nrf/src/lib.rs
+++ b/embassy-boot/nrf/src/lib.rs
@ -100,6 +100,13 @@ impl BootLoader {

        trace!("msp = {=u32:x}, rv = {=u32:x}", msp, rv);

+        // These instructions perform the following operations:
+        //
+        // * Modify control register to use MSP as stack pointer (clear spsel bit)
+        // * Synchronize instruction barrier
+        // * Initialize stack pointer (0x1000)
+        // * Set link register to not return (0xFF)
+        // * Jump to softdevice reset vector
        core::arch::asm!(
            "mrs {tmp}, CONTROL",
            "bics {tmp}, {spsel}",